Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in Objective.copy() #139

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Fix a bug in Objective.copy() #139

merged 1 commit into from
Apr 4, 2022

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fantaosha fantaosha added the bug Something isn't working label Apr 4, 2022
@fantaosha fantaosha self-assigned this Apr 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2022
@mhmukadam mhmukadam merged commit b71714e into main Apr 4, 2022
@mhmukadam mhmukadam deleted the taoshaf.fix_objective_copy branch April 4, 2022 14:31
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@fantaosha
fix a bug in Objective.copy (facebookresearch#139)
16e0381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@luisenp luisenp luisenp approved these changes

Assignees

@fantaosha fantaosha

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantaosha @luisenp @mhmukadam @facebook-github-bot