Change unit tests to avoid making mypy a main requirement. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisenp
added
bug
facebook-github-bot
added
the
CLA Signed
mhmukadam
reviewed
Apr 15, 2022
mhmukadam
reviewed
Apr 15, 2022
mhmukadam
reviewed
Apr 15, 2022
mhmukadam
approved these changes
Apr 15, 2022
luisenp
added a commit
that referenced
this pull request
Apr 26, 2022
* Change unit tests to avoid making mypy a main requirement. (#168) * Change unit tests to avoid making mypy a main requirement. * Added back dev requirements to CI. * Wording change. * Update readme and contrib (#169) * Change unit tests to avoid making mypy a main requirement. * Added back dev requirements to CI. * Removed thanks file. * Add missing license header in test_urdf_model * Add ManifoldGaussian class for messages in belief propagation (#121) * Gaussian class to wrap Manifold class and lam matrix for inverse covariance * reformatted * restored original manifold file * initial attempt at marginal class , need to handle batch dim * added standard fns dtype, to, copy, update * single to call in init * renamed ManifoldGaussian * setting precision in init with checks * update function requires mean and precision * fixed naming in init * manifold gaussian tests * retract and local gaussian fns * check precision is a symmetric matrix * moved retract and local gaussian to manifold_gaussian to avoid circular imports * added ManifoldGaussian to inits * minor edits * fixed dtype error in se3 that appeared in unit tests * add checks for local_gaussian * tests for local and retract gaussian * import from th. * added local_gaussian retract_gaussian to init, minor fix * minor fix on value error * fixed copy bug and added comments * random precision matrix in unit tests * fix for random precision * init precision with identity * fixed typo * More efficient implementation of forward kinematics (#175) * Bump DRM version and adapt API * Add small tolerences to tests to account for numerical errors * Changing setup virtualenv command. (#178) * Updated SDF object in collision cost functions whenever an aux var is updated (#177) * Updated SDF object in collision cost functions whenever an aux var is updated. * Changed gather_from_rows_cols to support matrix broadcasting. Co-authored-by: Mustafa Mukadam <mukadam.mh@gmail.com> Co-authored-by: Joe Ortiz <joeaortiz16@gmail.com> Co-authored-by: Austin Wang <austinswang@gmail.com>
luisenp
added a commit
that referenced
this pull request
Apr 26, 2022
* Change unit tests to avoid making mypy a main requirement. * Added back dev requirements to CI. * Wording change.
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
…esearch#168) * Change unit tests to avoid making mypy a main requirement. * Added back dev requirements to CI. * Wording change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #167