Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and contrib #169

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Update readme and contrib #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c452a7
Change unit tests to avoid making mypy a main requirement.
luisenp Apr 15, 2022
81afe69
Added back dev requirements to CI.
luisenp Apr 15, 2022
6636f53
Removed thanks file.
luisenp Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ pip install pre-commit && pre-commit install && pre-commit run --all-files

- We encourage more smaller and focused PRs rather than big PRs with many independent changes.
- Use this [PR template](.github/PULL_REQUEST_TEMPLATE.md) to submit your code for review. Consider using the [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/) option to gather early feedback.
- Add yourself to the `Assignees`, add at least one [core Theseus team](THANKS.md) member to `Reviewers`, link to any open issues that can be closed when the PR is merged, and add appropriate `Labels` and `Milestone`.
- Add yourself to the `Assignees`, add [Mustafa Mukadam](https://github.com/mhmukadam) and [Luis Pineda](https://github.com/luisenp) as reviewers, link to any open issues that can be closed when the PR is merged, and add appropriate `Labels` and `Milestone`.
- We expect the PR is ready for final review only if Continuous Integration tests are passing.
- Keep your branch up-to-date with `main` by rebasing as necessary.
- We employ `squash-and-merge` for incorporating PRs. Add a brief change summary to the commit message.
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ The current focus is on nonlinear least squares with support for sparsity, batch

- Use [Github issues](https://github.com/facebookresearch/theseus/issues/new/choose) for questions, suggestions, and bugs.
- See [CONTRIBUTING](https://github.com/facebookresearch/theseus/blob/main/CONTRIBUTING.md) if interested in helping out.
- Theseus is being developed with the help of many contributors, see [THANKS](https://github.com/facebookresearch/theseus/blob/main/THANKS.md).


## License
Expand Down
11 changes: 0 additions & 11 deletions THANKS.md
View file
Open in desktop

This file was deleted.