Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to specify python versions and CUDA during install step + #207

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Update README to specify python versions and CUDA during install step + #207

merged 3 commits into from
Jun 9, 2022

Conversation

cpaxton
Copy link
Contributor

@cpaxton cpaxton commented Jun 9, 2022

Motivation and Context

Add notes on python version (required for scikit sparse) and on CUDA installation.

How Has This Been Tested

Built on my machine

Types of changes

  • [X ] Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@mhmukadam mhmukadam merged commit 4492344 into facebookresearch:main Jun 9, 2022
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@cpaxton
Update README to specify python versions and CUDA during install step…
ca01b29 
… + (facebookresearch#207)

* Update README to specify python versions and CUDA during install step +
dd vim to gitignore

* update to mention that nvcc check is only needed for GPU support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpaxton @mhmukadam @facebook-github-bot