Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objective.error() no longer updates vectorization if also_update=False. #401

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Objective.error() no longer updates vectorization if also_update=False. #401

merged 1 commit into from
Jan 11, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Dec 15, 2022

Avoids unnecessary extra calls to vectorization update.

@luisenp luisenp added the enhancement New feature or request label Dec 15, 2022
@luisenp luisenp self-assigned this Dec 15, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2022
@luisenp luisenp merged commit 395b7de into main Jan 11, 2023
@luisenp luisenp deleted the lep.reduce_unnecessary_vectorization_in_error branch January 11, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot