Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lie Labs API v3 #494

Merged
merged 10 commits into from
Apr 21, 2023
Merged

Lie Labs API v3 #494

merged 10 commits into from
Apr 21, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Apr 5, 2023

Addresses comments from #476.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2023
mhmukadam
mhmukadam reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding all the updates from feedback on alpha. Left some minor comments.

fantaosha
fantaosha reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. LGTM overall.

theseus/labs/lie/functional/lie_group.py Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Outdated Show resolved Hide resolved
theseus/labs/lie/lie_tensor.py Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Outdated Show resolved Hide resolved
mhmukadam
mhmukadam approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisenp luisenp merged commit a107a69 into main Apr 21, 2023
@luisenp luisenp deleted the lep.lie_labs_v3 branch April 21, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantaosha fantaosha fantaosha left review comments

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot