Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra eps for dlog #544

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Add extra eps for dlog #544

merged 1 commit into from
Jun 23, 2023

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fantaosha fantaosha requested a review from luisenp June 22, 2023 19:42
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2023
@fantaosha fantaosha changed the title Add extra eps for dog Add extra eps for dlog Jun 22, 2023
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this so quickly!

@luisenp luisenp merged commit d35a5d1 into main Jun 23, 2023
@luisenp luisenp deleted the taoshaf.lie_extra_eps branch June 23, 2023 03:17
@@ -42,12 +42,14 @@ def get_eps(self, ltype: str, attr: str, dtype: torch.dtype) -> float:
def reset(self) -> None:
self.so3_near_pi_eps_float32 = 1e-2
self.so3_near_zero_eps_float32 = 1e-2
self.so3_d_near_zero_eps_float32 = 2e-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging that these new ones would need to be added to options on the theseus side. Unless we refactor to something like the wrapper version based on this comment thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants