Experimental Raytrace now uses OkLCh as default and removes alternatives #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-configured oklch-raytrace and lch-raytrace are no longer provided. Users can easily recreate such pre-configured methods and we now document how. CIELab when gamut mapped tightly, as the ray trace method does, gives very washed out yellows for extreme cases due to the geometry of the space. Oklab does much better in this area. CIELab will give more consistent results at general extremes, while Oklab breaks down near where the visible spectrum ends, especially in the blue region. We will go with the Oklab as more practical colors within the visible spectrum map fairly decently and people coming from CSS will likely prefer similar behavior. The option to use CIELAB, Luv, etc. are readily available for anyone that requires it.
gir-bot
added
S: needs-review
|
@gir-bot lgtm |
gir-bot
added
S: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-configured oklch-raytrace and lch-raytrace are no longer provided. Users can easily recreate such pre-configured methods and we now document how.
CIELab when gamut mapped tightly, as the ray trace method does, gives very washed out yellows for extreme cases due to the geometry of the space. Oklab does much better in this area. CIELab will give more consistent results at general extremes, while Oklab breaks down near where the visible spectrum ends, especially in the blue region. We will go with the Oklab as more practical colors within the visible spectrum map fairly decently and people coming from CSS will likely prefer similar behavior. The option to use CIELAB, Luv, etc. are readily available for anyone that requires it.