Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LambdaService to specify defaults #33

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

s-fletcher
Copy link
Contributor

  • Deprecates defaultScopes in favor of defaults.scopes
  • Allows developers to overwrite the default memorySize and timeout properties for all api handlers.

reservedConcurrentExecutions: definition.reservedConcurrentExecutions,
timeout: definition.timeout
? cdk.Duration.seconds(Math.max(30, definition.timeout))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL we max this out to 30 seconds. That's useful to know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I was the one who wrote this comment 🤦‍♂️ https://github.com/faceteer/cdk/blob/main/handlers/api-handler.ts#L56-L61

@github-actions
Copy link

github-actions bot commented Jul 14, 2022

Unit Test Results

  1 files  ±0    6 suites  ±0   5s ⏱️ -1s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ±0 
22 runs  ±0  22 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 63e4fb5. ± Comparison against base commit ed476b0.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #33 (0b7d3de) into main (ed476b0) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b7d3de differs from pull request most recent head 63e4fb5. Consider uploading reports for the commit 63e4fb5 to get more accurate results

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          13       13           
  Lines         369      369           
  Branches       84       82    -2     
=======================================
  Hits          313      313           
  Misses         56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed476b0...63e4fb5. Read the comment docs.

@s-fletcher s-fletcher merged commit 0d3082e into main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants