Support Arm64 architecture in Lambda handlers #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 82.69% 82.77% +0.08%
==========================================
Files 24 24
Lines 624 627 +3
Branches 142 144 +2
==========================================
+ Hits 516 519 +3
Misses 99 99
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SeriousBug
requested review from
s-fletcher,
loganhuskins,
mckalexee,
AnYoung627,
bill-kerr and
mckbas
loganhuskins
approved these changes
Dec 16, 2022
|
Superseded by #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Arm64 architecture in Lambda handlers. X86_64 is used by default, as they were before this PR.
Changing to Arm64 will reduce costs, but node packages that rely on native components may not work without additional effort as they will have to be compiled for Arm. However majority of node packages are javascript-only, so most handlers can switch to Arm with no additional effort.
The support is added using an
architecturefield, which can be defined either in the function definition to pick an architecture for that handler, or in the stack definitiondefaultsto set it globally.