Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate path parameters on deploy #6

Merged
merged 5 commits into from
May 16, 2022

Conversation

s-fletcher
Copy link
Contributor

This PR adds some validation while constructing lambdas to ensure that pathParameters properly represents what is on the route.

Screenshot of validation failing (with some debug statements added)

Screen Shot 2022-01-29 at 10 33 10 PM

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #6 (8b7ae56) into main (2ed7f0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files          11       11           
  Lines         338      338           
  Branches       80       80           
=======================================
  Hits          283      283           
- Misses         51       55    +4     
+ Partials        4        0    -4     
Impacted Files Coverage Δ
handlers/api-handler.ts 92.04% <ø> (ø)
handlers/queue-handler.ts 78.26% <0.00%> (ø)
response/failed-response.ts 80.00% <0.00%> (ø)
response/success-response.ts 69.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed7f0d...8b7ae56. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 30, 2022

Unit Test Results

  1 files  ±0    4 suites  ±0   5s ⏱️ -1s
17 tests ±0  17 ✔️ ±0  0 💤 ±0  0 ±0 
18 runs  ±0  18 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8b7ae56. ± Comparison against base commit 2ed7f0d.

♻️ This comment has been updated with latest results.

@s-fletcher s-fletcher merged commit 866b268 into main May 16, 2022
@s-fletcher s-fletcher deleted the validate-path-parameters-on-extraction branch May 16, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant