Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose send to queue options #8

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

bill-kerr
Copy link
Contributor

This PR exposes the SendMessagesOptions config object to the method returned by generateQueueSender. This was a previous feature of lambda handlers, but looks to have been left off in this recent version.

We will now be able to do something like:

Queues.sendEmail(messages, { randomDelay: 100 });

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #8 (7e77226) into main (beed574) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files          10       10           
  Lines         312      312           
  Branches       72       72           
=======================================
  Hits          251      251           
- Misses         57       61    +4     
+ Partials        4        0    -4     
Impacted Files Coverage Δ
handlers/queue-handler.ts 78.26% <33.33%> (ø)
response/failed-response.ts 73.33% <0.00%> (ø)
response/success-response.ts 69.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beed574...7e77226. Read the comment docs.

@mckalexee mckalexee merged commit ec665d5 into faceteer:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants