Initial db setup #27
Initial db setup #27
Conversation
Heathercoraje
requested review from
veredrec,
matthewdking,
a user and
sajedazoabi
|
pull the latest master and merge it with this branch |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 6 6
=====================================
Hits 6 6Continue to review full report at Codecov.
|
database/db_build.js
Outdated
| for (let i = 0; i < careers.length; i++) { | ||
| careers[i].save((error, result) => { | ||
| if (error) { | ||
| console.log(error); |
relates #16
database/db_build.js
Outdated
| career.collection.drop(); // once app is open, drop schema career | ||
|
|
||
| let dataLength = 0; | ||
| for (let i = 0; i < careers.length; i++) { |
There was a problem hiding this comment.
use a forEach instead cause then you won't need the dataLength var
database/db_build.js
Outdated
|
|
||
| db.once('open', () => { | ||
| console.log('we are connected to DB'); | ||
| career.collection.drop(); // once app is open, drop schema career |
database/db_build.js
Outdated
| }); | ||
| } | ||
|
|
||
| function exit () { |
src/index.js
Outdated
| db.once('open', function () { | ||
| console.log('connected to DB'); | ||
| app.listen(app.get('port'), () => { | ||
| console.log('Magic happens on port 8181!'); |
There was a problem hiding this comment.
the original one was a bit better, cause what if you wanted to change the port ???
also i would do
process.env.PORT || app.get('port')for heroku setup
| require('env2')('./congif.env'); | ||
|
|
||
| const db = mongoose.connection; | ||
| mongoose.connect(process.env.MONGODB_URI, { |
There was a problem hiding this comment.
do we need a whole different file for this ??
why not justg add it to the src/index.js ( which should be renamed )
#16
Create files database yet still needs to add codes in app.js to build db properly.