Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Clear line data #31

Closed
peci1 opened this issue Mar 28, 2017 · 5 comments
Closed

Feature request: Clear line data #31

peci1 opened this issue Mar 28, 2017 · 5 comments

Comments

@peci1
Copy link
Contributor

peci1 commented Mar 28, 2017

Thanks for the awesome package. One thing that I'd consider useful would be selectively clearing data of a single line (though not removing the "line object" itself), so that I can replay a bagfile and have the line data only from the last replay.

@facontidavide
Copy link
Owner

Let me rephrase it to see if I understand correctly what you mean.

You want to keep the line object (the term "curve" is used int ot he source code, therefore let's use that), i.e. the graphical representation.

This curve is always associated to a certain data stored in memory (and visualized in the list on the left side of the screen.

You want to load something that share the same name, but you don't want it to overwrite the old one.
This is currebtly impossible and can't be implemente in the way you described.

NEVERTHELESS, a solution I see is to provide a prefix to the name during the loaginf phase to keep the data separated. This is the low hanging fruit for me.

What do you think?

@peci1
Copy link
Contributor Author

peci1 commented Apr 1, 2017

Well, what you've described sounds more like #32.

What I meant here is the following:
I'm running a ROS-enabled simulator which publishes some data. I subscribe to these data for a while, view them in PlotJuggler, and then I change something, restart the simulator, and want to see the new data (and only the new data).

What happens now is that the data from the first run of the simulator are still displayed and get mixed with the data from the second run. What I want is to remove data from the first run, but keep the "curve specifications and settings" as they were. Ideally without having to delete the curves.

A UI I'd propose is another item in the context menu of a plot called "Clear curve data", which would empty the datasets connected to the displayed curves, but not the curves themselves. The easier way is to always delete all data from the plot. The more difficult (but also more fruitful) option is to show a dialog similar to "remove curves" to let the user select which curves should get cleared.

I hope I explained it better this time.

@facontidavide
Copy link
Owner

I guess that what you call "curve specifications and settings" is what I call "layout", i.e. the way curves are arranged into differente widgets and tabs.
Correct me if I am wrong.

I'm running a ROS-enabled simulator which publishes some data. I subscribe to these data for a while, view them in PlotJuggler, and then I change something, restart the simulator, and want to see the new data (and only the new data).

So you want something to clear the buffered data, but not the containers... I see. It is indeed possible but there is another solution. I can implement that easily in the streaming options.

Have you tried to save the layout ? You can Delete all data and then load the saved layout.

screenshot_1

facontidavide added a commit that referenced this issue Apr 2, 2017
@facontidavide
Copy link
Owner

Done (?)
Is this what you meant? 624836f

@peci1
Copy link
Contributor Author

peci1 commented Apr 3, 2017

Perfect, 624836f does exactly what I wanted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants