[bugfix] fix parsing of custom types added multiple times in messages #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest PlotJuggler I'm failing to decode some messages with the following error:
throw std::runtime_error("Missing ROSType in library");A common thread for the messages throwing this error is that they all contain the same custom types in multiple sub-entries. The result is that the reverse parsing of messages is not sufficient to capture all dependencies.
This PR suggests creating all the known types the first time through the messages and then filling in the packages only after. It is slightly less efficient, but correctly captures dependencies (as far as I can tell).