Add a simple notifier that prints stuff to the console. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class ConsoleNotifier(Notifier): | ||
| def notify(self, recipient, msg): | ||
| log.info('Message: {} For: {}'.format(msg.text, recipient)) |
There was a problem hiding this comment.
I think this should use the level of the Message, not just info?
| if msg.level == logging.CRITICAL: | ||
| log.critical('Message: {} For: {}'.format(msg.text, recipient)) | ||
| if msg.level == logging.ERROR: | ||
| log.error('Message: {} For: {}'.format(msg.text, recipient)) |
There was a problem hiding this comment.
Those level are only ints and people might define their own levels. You should maybe test for <= or >= in the proper order.
There was a problem hiding this comment.
Maybe we should just print it here. For simplicities sake?
|
Nice minimal example! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good idea to have the most simple example one can think of.
Also it can be used offline. Or without a phone. Or without an unimail thing.