Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify setting ENV #1

Closed
amandabee opened this issue Dec 13, 2018 · 4 comments
Closed

Clarify setting ENV #1

amandabee opened this issue Dec 13, 2018 · 4 comments

Comments

@amandabee
Copy link
Contributor

@knowtheory

At the top of the azure.rb we need to clarify setting the ENV variable -- if you set it in a virtualenv will that stick? Are you assuming a virtualenv? Or will that AZURE_KEY be available globally?

@knowtheory
Copy link
Contributor

knowtheory commented Dec 13, 2018

Yep! The Azure and GCP scripts both read some data off the commandline, i'd like to make the Azure script run the way the GCP one does (you pass a file in as an ENV variable) and then it does the right thing. But haven't gotten there yet, it's on the todo list:

  • make reading credential files from the commandline work
  • make the script explain what to do with credential files.

@knowtheory
Copy link
Contributor

Okay, the script now takes credentials if they are required. So for example you do this:

ruby ./lib/ocr.rb google google_cloud_vision/credentials.json documents/*

likewise the Azure instructions are:

ruby ./lib/ocr.rb azure azure/credentials.json documents/*

@amandabee
Copy link
Contributor Author

amandabee commented Jan 29, 2019 via email

@amandabee
Copy link
Contributor Author

Closing b/c the instructions have moved past this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants