Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig should be a peer dependency #14

Closed
mvsde opened this issue May 17, 2022 · 0 comments · Fixed by #20
Closed

Twig should be a peer dependency #14

mvsde opened this issue May 17, 2022 · 0 comments · Fixed by #20

Comments

@mvsde
Copy link
Member

mvsde commented May 17, 2022

At the moment Twig.js is a dev dependency:

eleventy-plugin-twig/package.json

Line 37 in 3fc7c23

"twig": "^1.15.4"

It should be a peer dependency and the readme should include twig as part of the install command:

eleventy-plugin-twig/README.md

Line 33 in 3fc7c23

$ npm install --save-dev @factorial/eleventy-plugin-twig

e.g.

npm install --save-dev @factorial/eleventy-plugin-twig twig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add twig as a peerDependency instead of devDependency factorial-io/eleventy-plugin-twig
1 participant
@mvsde