Change CachedDataPoints access modifier to public #613
Comments
TheBoegl
added a commit
to TheBoegl/chart-fx
that referenced
this issue
Sep 21, 2023
This commit changes the access modifier for the CachedDataPoints class to public and fixes fair-acc#613. It also makes it easier to customize the error data set renderer and avoids split packages.
wirew0rm
pushed a commit
that referenced
this issue
Sep 22, 2023
This commit changes the access modifier for the CachedDataPoints class to public and fixes #613. It also makes it easier to customize the error data set renderer and avoids split packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Classes that extend the ErrorDataSetRenderer and override any of the
draw*(GraphicsContext, CachedDataPoints): voidmethods must be placed in the same package (de.gsi.chart.renderer.spiorio.fair_acc.chartfx.renderer.spi) because CachedDataPoints has only package private class access and is exposed outside of its defined visibility scope.If there are no objections, we should change the access modifier to public. This will make it easier to customize the error data set renderer and to avoid split packages.
Let me know if you are interested in a PR for this small change.
Environment:
The text was updated successfully, but these errors were encountered: