Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frank/metadata propagation #164

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Frank/metadata propagation #164

merged 6 commits into from
Mar 8, 2024

Conversation

frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Feb 23, 2024 •
edited
Loading

Adapt to latest graph-prototype:

  • Use delay in test block to receive all data.
  • Use messages for scheduler control/communication in GnuRadioWorker (simplifies the service<->scheduler thread interaction).

Expand tests to ensure that metadata configured at the GR sources (in GRC) make it to the data sink and from there to the REST client.

@wirew0rm wirew0rm linked an issue Feb 29, 2024 that may be closed by this pull request
[2SP, 2SP] Service: Ensure signal metadata is propagated from source in the remote flowgraph via the RemoteSource to the local flowgraph #160
Closed
3 tasks
@frankosterfeld frankosterfeld mentioned this pull request Feb 29, 2024
Closed
3 tasks
@frankosterfeld
README: Fix typo
795d27d
@frankosterfeld
RemoteSource: Forward remote signal metadata
098e30b
@frankosterfeld
GnuRadioWorker: Fix metadata handling
66cae3d 
The automatic forwarding uses the shortKey (e.g. "signal_name") instead
of they key ("key::signal_name").
@frankosterfeld
CountSource: Remove initial delay
9266525 
This can now be achieved with gr::testing::Delay.
@frankosterfeld frankosterfeld marked this pull request as ready for review March 7, 2024 21:35
@frankosterfeld
Adapt to graph-prototype changes
a7bd904 
As the sinks now register themselves only when started, we need an
initial delay in processing to get all data in the test listener.
Use gr::testing::Delay for that.

That also removes the need for the workaround for sinks being mixed
up in simultaneously existing gr::Graphs. That's fine now, as long
only one graph is executed by a scheduler, at a time.

To force-stop the scheduler, use message ports instead of polling
isProcessing.
@frankosterfeld
Do not spam console for unknown signals
fa3cf4e
RalphSteinhagen
RalphSteinhagen approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@RalphSteinhagen RalphSteinhagen merged commit 7f581cf into main Mar 8, 2024
9 checks passed
@RalphSteinhagen RalphSteinhagen deleted the frank/metadata-propagation branch March 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frankosterfeld @RalphSteinhagen