-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wam hackaton ci and google chrome csv import #9
Feature/wam hackaton ci and google chrome csv import #9
Conversation
Implement a build workflow for Linux. Ref: fairDataSociety#1
Requires Xcode license
Linter complains about dialog.NewProgressInfinite() deprecation: dialog.NewProgressInfinite is deprecated: Create a new custom dialog with a widget.ProgressBarInfinite() inside. (SA1019) there is still an open ticket fyne-io/fyne#2782 on difference against the new implementation. Exclude these from linter and consider refactoring.
The current table width for domains and users turned out to be too narrow in most cases. Increase the width of the two columns for better readability.
Brave export. It is possible to export all Google Chrome/Brave passwords to a CSV file. The expected input format of the CSV file is: name,url,username,password discord.com,https://discord.com/login,youremail@gmail.com,your_secure_password github.com,https://github.com/session,youremail@gmail.com,your_secure_password The first line will be omitted. Ref: fairDataSociety#8
Closing the pull request as won't merge. There was no communication and will to review for the last 10 days. |
Hi @gitcoindev Thank you for your participation at WAM and your work you did on this issue. Although it didn't meet the complete requirement list, the parts you did would be very useful and supportive for the FairOS Password manager workflow. If you would be interested, we can also continue on the FDS Discord (sent you a friend request, I hope I have the right user). |
Hello @gitcoindev, The changes in the PR can be easily merged. Just wanted to ask one thing, is there any specific reason that you didn't use matrix for the build process on different operating system? |
Hi @asabya, there was no specific reason. I can try to refactor the build process to use matrix, will let you know when it's completed. Should be ready today, tomorrow at the latest. |
Hi @asabya I refactored the build process to use GitHub matrix and I also added release configuration with GitHub matrix support. An example is available at https://github.com/gitcoindev/FairPass/releases/tag/v0.0.8 and the logs at https://github.com/gitcoindev/FairPass/actions/runs/2196043913 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is my submission for WAM hackathon, I described the pull request at https://hackmd.io/@en6I0FFLT6iJvOcdkCuOXg/SkgEOqlGc . Thank you for reviewing it!