Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wam hackaton ci and google chrome csv import #9

Conversation

gitcoindev
Copy link
Contributor

Hi, this is my submission for WAM hackathon, I described the pull request at https://hackmd.io/@en6I0FFLT6iJvOcdkCuOXg/SkgEOqlGc . Thank you for reviewing it!

gitcoindev and others added 20 commits March 15, 2022 09:42
Implement a build workflow for Linux.

Ref: fairDataSociety#1
Requires Xcode license
Linter complains about dialog.NewProgressInfinite() deprecation:
dialog.NewProgressInfinite is deprecated: Create a new custom dialog with a widget.ProgressBarInfinite() inside. (SA1019)

there is still an open ticket fyne-io/fyne#2782 on difference against the new implementation.

Exclude these from linter and consider refactoring.
The current table width for domains and users turned out to be too
narrow in most cases. Increase the width of the two columns for better
readability.
Brave export.

It is possible to export all Google Chrome/Brave passwords to a CSV
file.

The expected input format of the CSV file is:

name,url,username,password
discord.com,https://discord.com/login,youremail@gmail.com,your_secure_password
github.com,https://github.com/session,youremail@gmail.com,your_secure_password

The first line will be omitted.

Ref: fairDataSociety#8
@gitcoindev
Copy link
Contributor Author

Closing the pull request as won't merge. There was no communication and will to review for the last 10 days.

@gitcoindev gitcoindev closed this Mar 28, 2022
@crtahlin
Copy link

crtahlin commented Apr 7, 2022

Hi @gitcoindev

Thank you for your participation at WAM and your work you did on this issue.

Although it didn't meet the complete requirement list, the parts you did would be very useful and supportive for the FairOS Password manager workflow.

If you would be interested, we can also continue on the FDS Discord (sent you a friend request, I hope I have the right user).

@gitcoindev gitcoindev reopened this Apr 19, 2022
@gitcoindev
Copy link
Contributor Author

Hi @crtahlin , @asabya I am back. Please let me know which parts of the pull request to remove or rework. Let's work on merging this ! -)

@asabya
Copy link
Collaborator

asabya commented Apr 20, 2022

Hello @gitcoindev, The changes in the PR can be easily merged. Just wanted to ask one thing, is there any specific reason that you didn't use matrix for the build process on different operating system?

@gitcoindev
Copy link
Contributor Author

Hi @asabya, there was no specific reason. I can try to refactor the build process to use matrix, will let you know when it's completed. Should be ready today, tomorrow at the latest.

@gitcoindev
Copy link
Contributor Author

Hi @asabya I refactored the build process to use GitHub matrix and I also added release configuration with GitHub matrix support. An example is available at https://github.com/gitcoindev/FairPass/releases/tag/v0.0.8 and the logs at https://github.com/gitcoindev/FairPass/actions/runs/2196043913 .

Copy link
Collaborator

@asabya asabya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tfius @crtahlin should we merge this?

@tfius
Copy link
Contributor

tfius commented Apr 22, 2022

LGTM. @tfius @crtahlin should we merge this?

yes

@asabya asabya merged commit 2d17867 into fairDataSociety:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants