Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename network config parameter to be less ambiguous #471

Closed
rampall opened this issue Apr 13, 2023 · 1 comment
Closed

Rename network config parameter to be less ambiguous #471

rampall opened this issue Apr 13, 2023 · 1 comment

Comments

@rampall
Copy link

rampall commented Apr 13, 2023

Describe the bug
network config parameter is too generic and causes way too much confusion.
Naming it to ens-network or something more specific about what it really does would make it less ambigous.
@asabya
Copy link
Collaborator

asabya commented Apr 14, 2023

ens-network will be suitable.

asabya added a commit that referenced this issue May 4, 2023
@asabya
#471 network flag changed to ens-network
bfe41e2
@asabya asabya closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rampall @asabya