Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate finance #131

Merged
merged 5 commits into from
Jan 14, 2022
Merged

feat: migrate finance #131

merged 5 commits into from
Jan 14, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 13, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 13, 2022
@Shinigami92 Shinigami92 mentioned this pull request Jan 13, 2022
27 tasks
* @param min
* @param max
* @param dec
* @param symbol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add autoFormat

*/
currencyCode() {
return this.faker.random.objectElement(
this.faker.definitions.finance.currency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put undefined into it, to fix this error or change the 2 param in objectElement to be optional

Copy link
Member

@prisis prisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

src/finance.ts Outdated

while (!symbol) {
symbol = this.faker.random.objectElement(
this.faker.definitions.finance.currency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the last comment on this function

@prisis
Copy link
Member

prisis commented Jan 13, 2022

Maybe we can reuse https://github.com/phuoc-ng/fake-numbers to have correct ibans generated, saw some issues in the old faker

@Shinigami92 Shinigami92 marked this pull request as ready for review January 14, 2022 17:19
@Shinigami92 Shinigami92 merged commit 7a81a14 into migrate-to-typescript Jan 14, 2022
@Shinigami92 Shinigami92 deleted the migrate-finance branch January 14, 2022 17:19
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
damienwebdev pushed a commit that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants