-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate finance #131
Conversation
* @param min | ||
* @param max | ||
* @param dec | ||
* @param symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add autoFormat
*/ | ||
currencyCode() { | ||
return this.faker.random.objectElement( | ||
this.faker.definitions.finance.currency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put undefined into it, to fix this error or change the 2 param in objectElement to be optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments
src/finance.ts
Outdated
|
||
while (!symbol) { | ||
symbol = this.faker.random.objectElement( | ||
this.faker.definitions.finance.currency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the last comment on this function
Maybe we can reuse https://github.com/phuoc-ng/fake-numbers to have correct ibans generated, saw some issues in the old faker |
1a675d7
to
542bde6
Compare
No description provided.