Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert pnpm only-allow #291

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: revert pnpm only-allow #291

merged 1 commit into from
Jan 25, 2022

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Jan 25, 2022

Fixes #290

@damienwebdev damienwebdev requested a review from a team as a code owner January 25, 2022 01:03
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more that this.
Please all yarn related files and the package-lock.json to gitignore
Also before the eslint PR is not merged, we also need to add them additionally to eslintignore

@prisis
Copy link
Member

prisis commented Jan 25, 2022

The problem with the script stuff is, it's only working in monorepro correctly... If you put it into normal package ever user is calling it on install

@Shinigami92
Copy link
Member

Okay, we already have these:

faker/.gitignore

Lines 90 to 92 in 3bd98a6

# Invalid project lock files
package-lock.json
yarn.lock

We need to add .yarn/ but will do this in an extra PR so we can release a hotfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install fails for package consumers due to "only-allow pnpm"
4 participants