Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(finance): Update Belarusian Ruble to new version #1392

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Sep 26, 2022

I updated the code and symbol according to wikipedia.
See https://en.wikipedia.org/wiki/Belarusian_rubel#Third_rubel,_2016%E2%80%93present

@AdriVanHoudt AdriVanHoudt marked this pull request as ready for review September 26, 2022 15:03
@AdriVanHoudt AdriVanHoudt requested a review from a team as a code owner September 26, 2022 15:03
@import-brain import-brain requested a review from a team September 26, 2022 15:09
@import-brain import-brain added c: bug Something isn't working p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 26, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1392 (6992358) into main (3eaf005) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2163     2163              
  Lines      241303   241303              
  Branches     1014     1013       -1     
==========================================
- Hits       240399   240396       -3     
- Misses        883      886       +3     
  Partials       21       21              
Impacted Files Coverage Δ
src/locales/en/finance/currency.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 81.74% <0.00%> (-0.80%) ⬇️

@xDivisionByZerox xDivisionByZerox added the c: locale Permutes locale definitions label Sep 26, 2022
AdriVanHoudt added a commit to AdriVanHoudt/faker that referenced this pull request Sep 26, 2022
@ST-DDT ST-DDT merged commit 526906f into faker-js:main Sep 26, 2022
@AdriVanHoudt AdriVanHoudt deleted the patch-1 branch September 26, 2022 16:37
AdriVanHoudt added a commit to AdriVanHoudt/faker that referenced this pull request Sep 26, 2022
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants