Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark mersenne as deprecated (internal) #1429

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 11, 2022

Marks the Mersenne Module as deprecated, because it will be an internal module in the future.

Preparatory work for #1348 .

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 11, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Oct 11, 2022
@ST-DDT ST-DDT requested review from a team October 11, 2022 18:30
@ST-DDT ST-DDT self-assigned this Oct 11, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) October 11, 2022 18:30
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1429 (5f8f5b9) into main (f921c14) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2166     2166           
  Lines      237445   237450    +5     
  Branches     1040     1040           
=======================================
+ Hits       236538   236543    +5     
  Misses        886      886           
  Partials       21       21           
Impacted Files Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)
src/modules/mersenne/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT merged commit 7a3136c into main Oct 11, 2022
@ST-DDT ST-DDT deleted the chore/internal-mersenne branch October 11, 2022 18:49
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants