-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(string): adds support for generating ULID #2524
Open
brunocleite
wants to merge
11
commits into
faker-js:next
Choose a base branch
from
brunocleite:feat/adds-support-for-ulid-generation
base: next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4bb549a
feat(string): adds support for generating ULID
brunocleite 493c3e0
Merge branch 'next' into feat/adds-support-for-ulid-generation
brunocleite b6dc97b
Merge branch 'next' into feat/adds-support-for-ulid-generation
brunocleite b63d07b
Merge branch 'next' into feat/adds-support-for-ulid-generation
ST-DDT 9ba1bbe
fix(string): update ulid values (#2648)
brunocleite 12fed6e
Merge remote-tracking branch 'origin/feat/adds-support-for-ulid-gener…
brunocleite f41fd27
Merge branch 'next' into feat/adds-support-for-ulid-generation
ST-DDT 6e7a967
feat(string): updates ulid implementation using refDate
brunocleite 70a4bf4
Merge remote-tracking branch 'origin/feat/adds-support-for-ulid-gener…
brunocleite 702061d
feat(string): updates ulid refDate documentation
brunocleite 6fcba2c
fix(string): updates ulid regex to match all possible ULID values
brunocleite File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment was more about adding a comment to explain the magic numbers than to add an refDate parameter.
Nevertheless instead of copying the implementation, we should export the toDate function as internal helper and reuse it here.