Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-string-replace-all #2653

Merged
merged 7 commits into from
Feb 18, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 requested a review from a team as a code owner February 9, 2024 18:10
@Shinigami92 Shinigami92 self-assigned this Feb 9, 2024
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent breaking change Cannot be merged when next version is not a major release c: infra Changes to our infrastructure or project setup labels Feb 9, 2024
@Shinigami92 Shinigami92 changed the title infra(unicorn): prefer-string-replace-all infra(unicorn)!: prefer-string-replace-all Feb 9, 2024
@Shinigami92 Shinigami92 requested a review from a team February 9, 2024 18:14
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec5609b) 99.55% compared to head (b377a8d) 99.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2653    +/-   ##
========================================
  Coverage   99.55%   99.55%            
========================================
  Files        2817     2817            
  Lines      251199   251202     +3     
  Branches      724     1125   +401     
========================================
+ Hits       250082   250091     +9     
+ Misses       1117     1082    -35     
- Partials        0       29    +29     
Files Coverage Δ
src/modules/color/index.ts 99.79% <100.00%> (ø)
src/modules/finance/iban.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.98% <100.00%> (ø)
src/modules/helpers/luhn-check.ts 100.00% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 99.20% <100.00%> (ø)
src/modules/string/index.ts 100.00% <100.00%> (ø)
src/modules/system/index.ts 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

@ST-DDT ST-DDT mentioned this pull request Feb 9, 2024
@Shinigami92 Shinigami92 changed the title infra(unicorn)!: prefer-string-replace-all infra(unicorn): prefer-string-replace-all Feb 9, 2024
docs/guide/upgrading_v9/2121.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Feb 16, 2024
import-brain
import-brain previously approved these changes Feb 17, 2024
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain and ST-DDT via b377a8d February 18, 2024 21:45
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 18, 2024 21:46
@Shinigami92 Shinigami92 merged commit 52b8992 into next Feb 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants