-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(unicorn): prefer-string-replace-all #2653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Nothing urgent
breaking change
Cannot be merged when next version is not a major release
c: infra
Changes to our infrastructure or project setup
labels
Feb 9, 2024
Shinigami92
changed the title
infra(unicorn): prefer-string-replace-all
infra(unicorn)!: prefer-string-replace-all
Feb 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2653 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 2817 2817
Lines 251199 251202 +3
Branches 724 1125 +401
========================================
+ Hits 250082 250091 +9
+ Misses 1117 1082 -35
- Partials 0 29 +29
|
ST-DDT
reviewed
Feb 9, 2024
Shinigami92
changed the title
infra(unicorn)!: prefer-string-replace-all
infra(unicorn): prefer-string-replace-all
Feb 9, 2024
ST-DDT
requested changes
Feb 10, 2024
ST-DDT
previously approved these changes
Feb 16, 2024
import-brain
previously approved these changes
Feb 17, 2024
Shinigami92
dismissed stale reviews from import-brain and ST-DDT
via
February 18, 2024 21:45
b377a8d
ST-DDT
approved these changes
Feb 18, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Cannot be merged when next version is not a major release
c: infra
Changes to our infrastructure or project setup
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2439
Permanently enables the
unicorn/prefer-string-replace-all
lint rule.