-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document unstable icu sort order #2948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
c: infra
Changes to our infrastructure or project setup
labels
Jun 13, 2024
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2948 +/- ##
==========================================
- Coverage 99.96% 99.94% -0.02%
==========================================
Files 2987 2987
Lines 216052 216052
Branches 955 598 -357
==========================================
- Hits 215975 215942 -33
- Misses 77 110 +33 |
xDivisionByZerox
approved these changes
Jun 13, 2024
import-brain
approved these changes
Jun 15, 2024
matthewmayer
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
c: infra
Changes to our infrastructure or project setup
c: locale
Permutes locale definitions
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2905
This PR documents why we cannot sort the locale entries locale aware.