Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document unstable icu sort order #2948

Merged
merged 3 commits into from
Jun 16, 2024
Merged

docs: document unstable icu sort order #2948

merged 3 commits into from
Jun 16, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 13, 2024

Closes #2905

This PR documents why we cannot sort the locale entries locale aware.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: locale Permutes locale definitions c: infra Changes to our infrastructure or project setup labels Jun 13, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Jun 13, 2024
@ST-DDT ST-DDT requested review from a team June 13, 2024 21:28
@ST-DDT ST-DDT self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6d34cff
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/666defb5627a1b0008339ad9
😎 Deploy Preview https://deploy-preview-2948.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (b4e7d21) to head (6d34cff).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2948      +/-   ##
==========================================
- Coverage   99.96%   99.94%   -0.02%     
==========================================
  Files        2987     2987              
  Lines      216052   216052              
  Branches      955      598     -357     
==========================================
- Hits       215975   215942      -33     
- Misses         77      110      +33     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team June 14, 2024 19:36
@ST-DDT ST-DDT merged commit 25a1ab4 into next Jun 16, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/no-icu-sorting branch June 16, 2024 07:43
eLoyyyyy pushed a commit to eLoyyyyy/faker that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check whether the locale data should use locale aware sorting
4 participants