Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed node v12 from the pipe #309

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

prisis
Copy link
Member

@prisis prisis commented Jan 26, 2022

Because vitest is not supporting this version.

@prisis prisis added this to the v6.0.0 - Project stability milestone Jan 26, 2022
@prisis prisis requested a review from a team as a code owner January 26, 2022 09:23
@prisis prisis changed the title fix: removed node v12 from the pipe, because vitest is not supporting… fix: removed node v12 from the pipe Jan 26, 2022
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 26, 2022

We should do this end of march

https://nodejs.org/en/about/releases/

@prisis
Copy link
Member Author

prisis commented Jan 26, 2022

Please check https://github.com/faker-js/faker/runs/4947011110?check_suite_focus=true as example the pipe never runs and vitest is returning 0 as error code

ST-DDT
ST-DDT previously approved these changes Jan 26, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jan 26, 2022

The test pipeline does not work with node 12 and AFAICT the releases aren't build with node 12 either, so there is no point in keeping it.
If you wish to ensure that it can be build with node 12, then we should at least explicit turn of the test runs.

But I don't have a strong opinion on when to remove this.

Is there anything compatibility wise we have to consider when removing it?
(Aka does our build process ensure node 12 compatibility regardless of our build setup?)

doughlass
doughlass previously approved these changes Jan 26, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damienwebdev @JessicaSachs Please point out in next release notes that we officially drop node 12 support

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be updated to v14

"node": ">=12.0.0",

@ST-DDT
Copy link
Member

ST-DDT commented Jan 27, 2022

Couldn't we just drop official support for node 12 but give the users at least the chance to use it?
AFAICT we don't use any node 14+ features.

@Shinigami92
Copy link
Member

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines
As far as we don't set engine-strict, only a warning will show up

@prisis prisis dismissed stale reviews from doughlass and ST-DDT via 6031419 January 28, 2022 10:24
@Shinigami92 Shinigami92 requested review from ST-DDT and a team January 28, 2022 10:27
@Shinigami92 Shinigami92 merged commit 537f56e into faker-js:main Jan 28, 2022
@prisis prisis deleted the feauter/remove-node-12 branch January 28, 2022 12:11
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants