-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed node v12 from the pipe #309
fix: removed node v12 from the pipe #309
Conversation
We should do this end of march |
Please check https://github.com/faker-js/faker/runs/4947011110?check_suite_focus=true as example the pipe never runs and vitest is returning 0 as error code |
The test pipeline does not work with node 12 and AFAICT the releases aren't build with node 12 either, so there is no point in keeping it. But I don't have a strong opinion on when to remove this. Is there anything compatibility wise we have to consider when removing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damienwebdev @JessicaSachs Please point out in next release notes that we officially drop node 12 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to be updated to v14
Line 99 in 3242dfc
"node": ">=12.0.0", |
Couldn't we just drop official support for node 12 but give the users at least the chance to use it? |
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines |
Because vitest is not supporting this version.