Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve various todos #649

Merged
merged 8 commits into from
Mar 24, 2022
Merged

fix: solve various todos #649

merged 8 commits into from
Mar 24, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 21, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 21, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 21, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 21, 2022 20:35
src/lorem.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #649 (2f0ad2e) into main (7141cd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2f0ad2e differs from pull request most recent head fa172cd. Consider uploading reports for the commit fa172cd to get more accurate results

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176860   176852       -8     
  Branches      915      916       +1     
==========================================
- Hits       175690   175682       -8     
  Misses       1114     1114              
  Partials       56       56              
Impacted Files Coverage Δ
src/faker.ts 100.00% <ø> (ø)
src/address.ts 98.69% <100.00%> (-0.02%) ⬇️
src/internet.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <100.00%> (ø)
src/vendor/user-agent.ts 98.31% <0.00%> (-0.57%) ⬇️
src/vendor/unique.ts 95.16% <0.00%> (+1.61%) ⬆️

@Shinigami92 Shinigami92 requested review from ST-DDT and a team March 21, 2022 20:53
@ST-DDT ST-DDT requested a review from a team March 21, 2022 22:08
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 24, 2022 08:22
@Shinigami92 Shinigami92 merged commit d0a473f into main Mar 24, 2022
@Shinigami92 Shinigami92 deleted the fix-various-todos branch March 24, 2022 10:56
This was referenced Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants