Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add some en locale city prefixes and suffixes #685

Merged
merged 3 commits into from
Apr 5, 2022
Merged

feat: add some en locale city prefixes and suffixes #685

merged 3 commits into from
Apr 5, 2022

Conversation

import-brain
Copy link
Member

No description provided.

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 26, 2022
@import-brain import-brain requested a review from a team March 26, 2022 15:11
@import-brain import-brain requested a review from a team as a code owner March 26, 2022 15:11
@import-brain import-brain added the needs test More tests are needed label Mar 26, 2022
@import-brain import-brain removed the needs test More tests are needed label Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f22b93a). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head f65c914 differs from pull request most recent head 9ceccb9. Consider uploading reports for the commit 9ceccb9 to get more accurate results

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage        ?   99.34%           
=======================================
  Files           ?     1923           
  Lines           ?   176896           
  Branches        ?      897           
=======================================
  Hits            ?   175741           
  Misses          ?     1099           
  Partials        ?       56
Impacted Files Coverage Δ
src/locales/en/address/city_prefix.ts 100.00% <100.00%> (ø)
src/locales/en/address/city_suffix.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Mar 26, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 15:15
@Shinigami92 Shinigami92 merged commit 955ea43 into main Apr 5, 2022
@Shinigami92 Shinigami92 deleted the feat_en_prefix_suffix branch April 5, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@import-brain import-brain

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
4 participants
@import-brain @pkuczynski @ST-DDT @Shinigami92