feat: add music.songName #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 2112 2113 +1
Lines 225980 227001 +1021
Branches 980 982 +2
==========================================
+ Hits 225237 226253 +1016
- Misses 723 728 +5
Partials 20 20
|
import-brain
added
c: feature
import-brain
previously approved these changes
May 24, 2022
ST-DDT
requested changes
May 24, 2022
xDivisionByZerox
previously approved these changes
May 24, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
wingleungchoi
dismissed stale reviews from xDivisionByZerox and import-brain
via
a31158d
ST-DDT
approved these changes
May 24, 2022
import-brain
approved these changes
May 25, 2022
Shinigami92
approved these changes
May 25, 2022
Shinigami92
changed the title
Minozzzi
pushed a commit
to Minozzzi/faker
that referenced
this pull request
Jul 19, 2022
Co-authored-by: Wing Leung Choi <wchoi@and.digital>
xDivisionByZerox
added
m: music
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #162
Motivation: #162 (comment)
add faker.music.songName
contains the following special characters
(and'e.g."(I Can't Get No) Satisfaction"Top 1000 song list is based on https://manghammath.com/80s%20Hits/The%20Top%201000%20Songs%20of%20AllTime.pdf