Please use a different name for "class"

[thejonanshow]

So I was investigating some odd behavior in Ruby this evening and tried to find an object in memory based on it's ancestors with something like this:

os = []
ObjectSpace.each_object do |o| 
  os << o if o.class.ancestors.map(&:to_s).include? "PoorLostOrphanObject"
end

Imagine my surprise when I received the following error:

NoMethodError: undefined method `ancestors' for "Melee Assassin":String

Assuming that Ruby had not added some new Melee Assassin object that had escaped my attention I went looking for the culprit:

os = []; ObjectSpace.each_object { |o| os << o unless o.class.respond_to? :ancestors }
=> [Faker::Games::HeroesOfTheStorm]

I think it's fair to say we can all agree taking over a method like :class is pretty suboptimal, so I thought I'd make a PR to fix it, but I realized that someone, somewhere is most definitely using this code, and their tests will break with some equally confusing errors.

Any thoughts on how to go about undoing this one? There may not be any option but to rename this method hero_class or something similar and let their tests break. Maybe @illsism wants to recommend an alternative name?

faker/lib/faker/games/heroes_of_the_storm.rb

Lines 29 to 31 in 48fcc17

	def class
	fetch('heroes_of_the_storm.classes')
	end

[illsism]

Sure. I think specialization would be a better name.

[koic]

@thejonanshow Hi, Jonan 👋 Thank you for the feedback. I've opened #2031.

BTW, RubyKaigi 2020 cancellation announced today 😢
https://esa-pages.io/p/sharing/68/posts/1006/b15a58c675f5a69d06e5.html

Anyway, I'm glad to meet you on GitHub :-) Thank you.

[thejonanshow]

HI! 👋

I saw the news, it's very sad but I'm sure we'll get to meet our friends by the river again soon.

Thank you for the PR!