Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in lib/locales/README.md #2812

Merged
merged 10 commits into from
Aug 19, 2023

Conversation

BelaBartok39
Copy link
Contributor

Motivation / Background

My motivation is to get better at best practices by contributing small changes to my favorite teams.

Additional information

Fixed a very small typo in the locales/README.md file. Line 23.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typo!
The gemfile changes are unnecessary though.

Gemfile.lock Outdated Show resolved Hide resolved
lib/locales/README.md Outdated Show resolved Hide resolved
@thdaraujo thdaraujo changed the title fixed a very small typo in locale/README Fix typo in locale/README Aug 17, 2023
Copy link
Contributor Author

@BelaBartok39 BelaBartok39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Gemfile from accidently including on pull request.

Gemfile.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@thdaraujo thdaraujo changed the title Fix typo in locale/README Fix typo in lib/locales/README.md Aug 19, 2023
@thdaraujo thdaraujo merged commit 22f2b52 into faker-ruby:main Aug 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants