Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Faker::Internet.username should not generate duplicated punctuation #2970

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

thdaraujo
Copy link
Contributor

@thdaraujo thdaraujo commented Jun 19, 2024

[fixes #2967]

In #2950 there was a change on how email usernames were generated. This caused usernames to be generated with duplicate punctuation - for example:

Faker::Internet.email(name: 'Mr. Faker')
#=> faker.mr.@test.example
#=> mr._faker@test.example  

This PR restores the previous behavior when dealing with punctuation.

While we can't guarantee that any of these generated emails will be valid, we can restore the previous behaviour.

@thdaraujo thdaraujo self-assigned this Jun 19, 2024
@thdaraujo thdaraujo changed the title Ta/fix email dot separator fix: Faker::Internet.username should not generate duplicated punctuation Jun 19, 2024
@thdaraujo thdaraujo merged commit 0812ef0 into main Jun 20, 2024
8 checks passed
@thdaraujo thdaraujo deleted the ta/fix-email-dot-separator branch June 20, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version generates invalid email addresses
2 participants