[feature] Remove debugging statements in ring buffer source #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
added
enhancement
3 tasks
fako1024
commented
Aug 15, 2023
| @@ -398,8 +398,6 @@ func (s *Source) determineTotalPktLen(payload []byte) (uint16, error) { | |||
| return toUint16(payload[s.ipLayerOffset+4 : s.ipLayerOffset+6]), nil | |||
| } | |||
|
|
|||
| // TODO: What about jumbo packets? At least for IPv6 such packets carry additional | |||
There was a problem hiding this comment.
Note: I checked, regular Jumbo packets are handled correctly. Only IPv6 Jumbograms would fail as they carry extended information in the header (which would also affect the ring buffer source I assume). Unfortunately I wasn't able to simulate such packets (nor was I able to find a pcap source or similar). It seems its use is so uncommon that almost nobody has succeeded in crafting valid data that uses this feature, so I assume it's a non-issue in real life.
fako1024
deleted the
6-remove-debugging-statements-in-ring-buffer-source
branch
els0r
approved these changes
Sep 3, 2023
| golang.org/x/net v0.8.0 | ||
| golang.org/x/sys v0.6.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| go.uber.org/zap v1.25.0 |
There was a problem hiding this comment.
This could (aka should) be log/slog :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for initial release of slimcap. Will merge once all alpha tests check out.
Closes #6