Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

fix(dbt-fal): sqlserver quoting policy #859

Merged
merged 3 commits into from
Jun 1, 2023
Merged

fix(dbt-fal): sqlserver quoting policy #859

merged 3 commits into from
Jun 1, 2023

Conversation

mederka
Copy link
Collaborator

@mederka mederka commented May 31, 2023

Closes: #858

@mederka mederka requested a review from chamini2 May 31, 2023 08:50
@mederka mederka marked this pull request as ready for review May 31, 2023 08:51
chamini2
chamini2 approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/test_integration_adapter.yml Outdated Show resolved Hide resolved
@chamini2
Copy link
Member

it seems env tests are failing

Failing scenarios:
features/environments.feature:5 Run a project with a Python model that is calculated in a virtual environment
features/source.feature:9 Run a Python model that queries a source in local environment

Maybe it's fine for now

@mederka @chamini2
Update .github/workflows/test_integration_adapter.yml
bc4d123 
Co-authored-by: Matteo Ferrando <matteo.ferrando2@gmail.com>
@mederka mederka merged commit 51a28bd into release-adapter-1.4 Jun 1, 2023
@chamini2 chamini2 deleted the meder/fix/sqlserver-quoting-1.4 branch June 1, 2023 14:09
@fal-bot fal-bot mentioned this pull request Jun 1, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chamini2 chamini2 chamini2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mederka @chamini2