Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic migration #13

Merged
merged 91 commits into from
Mar 23, 2018
Merged

Logic migration #13

merged 91 commits into from
Mar 23, 2018

Conversation

jooohhn
Copy link
Member

@jooohhn jooohhn commented Jan 23, 2018 •
edited by amilajack
Loading

Work in Progress

  • Renamed App -> HomePage and created a new App component to wrap routes.
  • Necessary for nesting routes in react-router@4.*
  • Replace react-virtualized with handsontable
  • Re-enable progress bar
  • Table definition
  • Change falcon-core dep to amilajack/falcon-core
  • Query View
  • Structure View
  • Fix broken graph page
  • Migrate graphql-voyager to lerna
  • Fix merge conflicts

@jooohhn jooohhn self-assigned this Jan 23, 2018
amilajack
amilajack reviewed Jan 23, 2018
View reviewed changes
app/package.json Outdated
@@ -14,5 +14,7 @@
},
"license": "MIT",
"dependencies": {
"electron-store": "^1.2.0",
"falcon-core": "0.1.0-4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to https://github.com/amilajack/falcon-ui-rewrite-2/blob/master/app/package.json#L18. Master is correct here

internals/scripts/CheckBuiltsExist.js Outdated
@@ -9,15 +9,11 @@ function CheckBuildsExist() {
const rendererPath = path.join(__dirname, '..', '..', 'app', 'dist', 'renderer.prod.js');

if (!fs.existsSync(mainPath)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all the changes to the internals directory and any other boilerplate related files like webpack/babel/eslint changes. I have updated those in the repo already

@jooohhn jooohhn mentioned this pull request Jan 24, 2018
Closed
@jooohhn jooohhn force-pushed the logic-migration branch 3 times, most recently from 1842f0f to 6b3caa5 Compare January 25, 2018 18:47
@amilajack
Copy link
Member

amilajack commented Jan 31, 2018 •
edited
Loading

  • screen shot 2018-01-31 at 2 55 25 pm

The font size of the buttons changed in the last commit

  • Also the grid text should be left-aligned
  • Also that scrolling perf is 🔥 🔥 🔥 . Nice work 🎉

@jooohhn
Copy link
Member Author

jooohhn commented Jan 31, 2018

Had some problems with overflow:scroll using handsontable. I moved the <Footer> component out of <div className=".Grid">. Will fix before merge

@amilajack
Copy link
Member

Also:

screen shot 2018-01-31 at 3 01 55 pm

rows should be white like so:

screen shot 2018-01-31 at 3 02 09 pm

@amilajack
Copy link
Member

amilajack commented Feb 2, 2018 •
edited
Loading

Some overflow issues with the dropdown in structure view (pretty sure you know about this). Also we have to find a way to convert the ints to booleans or their correct corresponding values. Also did you port the functionality for the "yellow null boxes"?

@amilajack
Added start-prod script
247784a
@amilajack
Added 'package-all-no-build' script
110385b
@amilajack
Code cleanup
65837e8
@amilajack
Fixed flow import webpack issue
a4d2288
@amilajack
Iniital working in-house graphql-voyager commit
0521a0e
@amilajack
Initial lerna commit
0cd6e41
@amilajack
Initial working lerna commit
1484cfa
@amilajack
Removed git submodule
8fb21ce
@amilajack
Re-enabled optimization plugins (CommonShake, Lodash)
85998fd
@amilajack
Added svg-zoom package to lerna packages
9ece783
@amilajack
Updated .eslintignore
9bad91a
@amilajack
Added missing viz package
41bb8dc
@amilajack
Removed browser tests from linting
38ee483
@amilajack
Added and removed deps, updated readme setup steps
a4f5d6c
@amilajack
Added svg-pan-zoom dep to packages
94acf7f
@amilajack
Removed references to handsontable
c1bf487
@amilajack
Removed stand-alone.js
cb33b55
@amilajack
Ran alfred on svg-pan-zoom
5dc6a66
@amilajack
Removed browserify files
2b13643
@amilajack
Migrated deps to es6
2b14f2b
@amilajack
Added methods to svg-zoom
374d479
@amilajack
Merge branch 'master' into logic-migration
3c571ea
@amilajack
Added falcon-core to packages
c41073e
@amilajack
Reverted lerna falcon-core changes
d90bc05
@amilajack
Upgraded falcon-core dep
f876349
@amilajack
Reverted old readme instructions
c12eb7c
@amilajack amilajack merged commit 04e5220 into master Mar 23, 2018
@amilajack amilajack mentioned this pull request Mar 24, 2018
Merged
6 tasks
@amilajack amilajack mentioned this pull request Apr 14, 2018
Open
8 tasks
@amilajack amilajack deleted the logic-migration branch May 27, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilajack amilajack amilajack left review comments

Assignees

@jooohhn jooohhn

Labels
enhancement feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooohhn @amilajack