Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic migration #13

Merged
merged 91 commits into from
Mar 23, 2018
Merged

Logic migration #13

merged 91 commits into from
Mar 23, 2018

Conversation

jooohhn
Copy link
Member

@jooohhn jooohhn commented Jan 23, 2018

Work in Progress

  • Renamed App -> HomePage and created a new App component to wrap routes.
  • Necessary for nesting routes in react-router@4.*
  • Replace react-virtualized with handsontable
  • Re-enable progress bar
  • Table definition
  • Change falcon-core dep to amilajack/falcon-core
  • Query View
  • Structure View
  • Fix broken graph page
  • Migrate graphql-voyager to lerna
  • Fix merge conflicts

app/package.json Outdated
@@ -14,5 +14,7 @@
},
"license": "MIT",
"dependencies": {
"electron-store": "^1.2.0",
"falcon-core": "0.1.0-4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -9,15 +9,11 @@ function CheckBuildsExist() {
const rendererPath = path.join(__dirname, '..', '..', 'app', 'dist', 'renderer.prod.js');

if (!fs.existsSync(mainPath)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all the changes to the internals directory and any other boilerplate related files like webpack/babel/eslint changes. I have updated those in the repo already

@jooohhn jooohhn mentioned this pull request Jan 24, 2018
@jooohhn jooohhn force-pushed the logic-migration branch 3 times, most recently from 1842f0f to 6b3caa5 Compare January 25, 2018 18:47
@amilajack
Copy link
Member

amilajack commented Jan 31, 2018

  • screen shot 2018-01-31 at 2 55 25 pm

The font size of the buttons changed in the last commit

  • Also the grid text should be left-aligned
  • Also that scrolling perf is 🔥 🔥 🔥 . Nice work 🎉

@jooohhn
Copy link
Member Author

jooohhn commented Jan 31, 2018

Had some problems with overflow:scroll using handsontable. I moved the <Footer> component out of <div className=".Grid">. Will fix before merge

@amilajack
Copy link
Member

Also:

screen shot 2018-01-31 at 3 01 55 pm

rows should be white like so:

screen shot 2018-01-31 at 3 02 09 pm

@amilajack
Copy link
Member

amilajack commented Feb 2, 2018

Some overflow issues with the dropdown in structure view (pretty sure you know about this). Also we have to find a way to convert the ints to booleans or their correct corresponding values. Also did you port the functionality for the "yellow null boxes"?

@amilajack amilajack merged commit 04e5220 into master Mar 23, 2018
@amilajack amilajack mentioned this pull request Mar 24, 2018
6 tasks
@amilajack amilajack mentioned this pull request Apr 14, 2018
8 tasks
@amilajack amilajack deleted the logic-migration branch May 27, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants