fix(api_helpers): re-add falcon.api_helpers #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 63 +1
Lines 6591 6593 +2
Branches 1065 1065
=========================================
+ Hits 6591 6593 +2
Continue to review full report at Codecov.
|
vytas7
requested changes
Apr 6, 2021
|
thanks, updated |
kgriffs
approved these changes
Apr 12, 2021
| @@ -0,0 +1,7 @@ | |||
| from .app_helpers import * # NOQA | |||
There was a problem hiding this comment.
Nit: Should be two spaces before the #
There was a problem hiding this comment.
nit; using a formatter would take care of it :P
|
Is there a chance of getting these changes released? It prevents us from upgrading to falcon 3 as we rely on the sentry sdk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Re-add removed api_helpers package
Related Issues
closes #1902