fix(WebSocket): properly handle HTTPStatus and HTTPError cases #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2150 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6791 6802 +11
Branches 1095 1097 +2
=========================================
+ Hits 6791 6802 +11
|
vytas7
requested changes
May 25, 2023
|
thanks. I'll look into adding it and also by the coverage is not happy. |
vytas7
reviewed
Jun 3, 2023
vytas7
changed the title
|
thanks for fixing the coverage, I guess the old code was covering that part by chance |
vytas7
approved these changes
Jun 3, 2023
vytas7
changed the title
|
Thanks! |
vytas7
added a commit
that referenced
this pull request
Nov 12, 2023
* fix(websocket): properly handle HTTPStatus and HTTPError cases when using websockets * test: fix failing tests * test: add missing test coverage * docs: add newsfragment * chore: explicit raise for unsupported call of internal methods * style: fix imports * docs(towncrier): improve the bugfix newsfragment --------- Co-authored-by: Vytautas Liuolia <vytautas.liuolia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you think of further tests to try?
Fixes #2146