chore: remove pinning of importlib-resources for Mailman tests
#2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6830 6830
Branches 1098 1098
=========================================
Hits 6830 6830 |
|
Apparently it is still broken, maybe the Docker image needs to be updated 🤔 I'll need to check with @maxking. |
|
Closing, it is not as simple as that unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to pin
importlib-resourcesfor some CI gates because its very aggressive deprecation policy.Now the dependency in question has been dropped upstream, so we don't need to pin anymore (in fact, pinning breaks the gate): https://gitlab.com/mailman/mailman/-/merge_requests/1130.