Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more typing for Request/Response classes #2205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some more typing for Request/Response classes #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e20a8
Add type to Request stream
davetapley Jan 29, 2024
b6f62c3
Add type to Response text and _data
davetapley Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions falcon/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@

from datetime import datetime
from io import BytesIO
import sys
from uuid import UUID

if sys.version_info >= (3, 11):
from wsgiref.types import InputStream

Check warning on line 21 in falcon/request.py

View check run for this annotation

Codecov / codecov/patch

falcon/request.py#L21 

Added line #L21 was not covered by tests

from falcon import errors
from falcon import request_helpers as helpers
from falcon import util
Expand Down Expand Up @@ -454,6 +458,9 @@
# Child classes may override this
context_type = structures.Context

if sys.version_info >= (3, 11):
stream: InputStream

Check warning on line 462 in falcon/request.py

View check run for this annotation

Codecov / codecov/patch

falcon/request.py#L462 

Added line #L462 was not covered by tests

_wsgi_input_type_known = False

def __init__(self, env, options=None):
Expand Down
5 changes: 4 additions & 1 deletion falcon/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ class Response:
# Child classes may override this
context_type = structures.Context

text: Optional[str]
_data: Optional[bytes]

def __init__(self, options=None):
self.status = '200 OK'
self._headers = {}
Expand Down Expand Up @@ -227,7 +230,7 @@ def data(self):
return self._data

@data.setter
def data(self, value):
def data(self, value: bytes):
self._data = value

@property
Expand Down