feat(middleware): Add middleware method "process_resource" #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmansyed
force-pushed
the
middleware_process_resource
branch
3 times, most recently
from
d20d1a9
to
391044f
Compare
| \"""Process the request after routing. | ||
|
|
||
| Args: | ||
| req: Request object that will eventually be |
There was a problem hiding this comment.
At this point, the routing has occurred, so maybe reword this to:
"req: Request object that will be passed to the routed responder"
Create a new middleware method process_resource that occurs after process_request and routing, and ensure that the resource object is accessible. Additionally, make the resource object available to process_response. Issue falconry#400
rahmansyed
force-pushed
the
middleware_process_resource
branch
from
391044f
to
ead6357
Compare
|
Nice work! |
|
Nice job, LGTM. |
|
Thanks guys! My first open source contribution ever (long overdue). |
kgriffs
added a commit
that referenced
this pull request
Jan 30, 2015
feat(middleware): Add middleware method "process_resource"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new middleware method process_resource that occurs after process_request and routing, and ensure that the resource object is accessible. Additionally, make the resource object available to process_response.
Issue #400