feat(routing): New router architecture and faster default router #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from falcon.hooks import _wrap_with_hooks | ||
| from falcon import HTTP_METHODS, responders | ||
|
|
||
| from .compiled import CompiledRouter |
There was a problem hiding this comment.
For consistency, it would probably be good to not use a relative import.
|
Other than the relative import issue, LGTM. |
|
@jmvrbanac Fixed the relative import. I still need to update the API class docstring. |
kgriffs
force-pushed
the
routing
branch
4 times, most recently
from
fcd818f
to
38ac112
Compare
This replaces the routing logic with a new, faster strategy based on on-the-fly generation of Python code. As part of replacing the logic, the architecture has been refactored to decouple routing from falcon.API, thereby making it possible for users to easily replace the default router with their own. Closes falconry#114 Co-Authored-By: Kurt Griffiths <mail@kgriffs.com>
|
👍 LGTM |
jmvrbanac
added a commit
that referenced
this pull request
Apr 15, 2015
feat(routing): New router architecture and faster default router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the routing logic with a new, faster strategy based on on-the-fly
generation of Python code. As part of replacing the logic, the architecture has
been refactored to decouple routing from falcon.API, thereby making it possible
for users to easily replace the default router with their own.
Closes #114
Co-Authored-By: Kurt Griffiths mail@kgriffs.com