fix(util) Add support for obsolete HTTP date formats #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm
force-pushed
the
mcmaster/fix_255
branch
2 times, most recently
from
e31cec3
to
1cd1199
Compare
|
I will rebase this when #495 is merged, as I am pretty sure they conflict. |
|
@mcmasterathl when you have time, could you rebase your change? Thanks! |
|
Yup, was working on that right now actually. |
|
@jmvrbanac All set |
|
👍 LGTM |
mcm
force-pushed
the
mcmaster/fix_255
branch
2 times, most recently
from
92ed7d1
to
43bd487
Compare
Update http_date_to_dt to support obsolete date formats per RFC 7231. Fixes falconry#255
|
I think we could optimize this a bit, but that can be done in another patch. |
kgriffs
added a commit
that referenced
this pull request
Aug 21, 2015
fix(util) Add support for obsolete HTTP date formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update http_date_to_dt to support obsolete date formats per RFC 7231.
Fixes #255