Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(install) Warn about python updates when using cython #497

Merged
merged 1 commit into from
Apr 15, 2015

Conversation

mcm
Copy link
Contributor

@mcm mcm commented Apr 14, 2015

Closes #476

@@ -21,6 +21,14 @@ type:

$ pip install --upgrade falcon

When using Cython, you should always recompile Falcon after upgrading Python.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be clearer if you put this change into a .. note:: block

@mcm
Copy link
Contributor Author

mcm commented Apr 14, 2015

I moved the comment into a ..note block for clarity and emphasis.

@jmvrbanac
Copy link
Member

👍

@kgriffs
Copy link
Member

kgriffs commented Apr 15, 2015

LGTM, thanks!

kgriffs added a commit that referenced this pull request Apr 15, 2015
doc(install) Warn about python updates when using cython
@kgriffs kgriffs merged commit a63c6e5 into falconry:master Apr 15, 2015
@mcm mcm deleted the mcmaster/doc_476 branch April 16, 2015 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Warn about python updates when using cython
3 participants