feat(request): Add function to get param as date #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| Args: | ||
| name (str): Parameter name, case-sensitive (e.g., 'ids'). | ||
| format_string (str): String used to parse the param value into a date. # NOQA |
There was a problem hiding this comment.
The NOQA actually gets rendered in the sphinx docs, so we'll have to come up with a different solution. For this line, it can simply be wrapped.
|
Once the docstring is fixed up, LGTM |
A user requested a feature where a param could be automatically parsed into a date. closes falconry#293
|
Docstring cleaned up, let me know how it looks. |
| Args: | ||
| name (str): Parameter name, case-sensitive (e.g., 'ids'). | ||
| format_string (str): String used to parse the param value into a | ||
| date. |
There was a problem hiding this comment.
Looks like you'll need to indent this line to make sphinx happy (see attached). You can make the docs to check your changes:
pip install -r tools/doc-requires
cd doc
make html
open _built/html/index.html
|
Did this get merged? I can't tell if I need to rebase #493 on top of this functionality. |
|
Nope looks like I killed this prematurely. @kgriffs @jmvrbanac I submitted a new PR #519 for these changes, rebased to current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user requested a feature where a param could be automatically parsed into a date.
closes #293
Supersedes #487