Add support for setting the realm to the HTTPUnauthorized class #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: Issue #430 |
|
@ueg1990 Thanks for this! Would you mind ammending your commit message so the first line includes a prefix ala:
Also, please reference the issue in the footer on a line by itself, as in:
Thanks! |
| @@ -49,18 +49,17 @@ class HTTPUnauthorized(HTTPError): | |||
| title (str): Error title (e.g., 'Authentication Required'). | |||
| description (str): Human-friendly description of the error, along with | |||
| a helpful suggestion or two. | |||
| scheme (str): Authentication scheme to use as the value of the | |||
| WWW-Authenticate header in the response (default ``None``). | |||
| challenges (iterable of strings): Authentication scheme to use as the | |||
There was a problem hiding this comment.
"Authentication scheme" => "One or more authentication challenges to use as the value of the..."
|
@ueg1990 Looks like there's a minor pep8 error. |
|
👍 LGTM |
| @@ -49,18 +49,18 @@ class HTTPUnauthorized(HTTPError): | |||
| title (str): Error title (e.g., 'Authentication Required'). | |||
| description (str): Human-friendly description of the error, along with | |||
| a helpful suggestion or two. | |||
| scheme (str): Authentication scheme to use as the value of the | |||
| WWW-Authenticate header in the response (default ``None``). | |||
| challenges (iterable of strings): One or more authentication | |||
|
@ueg1990 Just one nitpick to address, and then I think this is ready to merge. |
|
@ueg1990 In preparation for the merge, would you mind squashing all the patches down to a single commit? You cant |
…nauthorized class Based on RFC 7235, add challenges to HTTP Unauthorized to indicate authentication scheme. A server generating a 401 must send a WWW-Authenticate header field containing at least one challenge BREAKING CHANGE: Add new parameter to the __init__ method of class HTTPUnauthorized to add determine authentication scheme in the WWW-Authenticate header field when a 401 (Unauthorized) is generated Fixes falconry#430 Fix pep8 error Fix docstring
kgriffs
added a commit
that referenced
this pull request
Jul 15, 2015
Add support for setting the realm to the HTTPUnauthorized class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on RFC 7235, add challenges to HTTP Unauthorized to indicate
authentication scheme. A server generating a 401 must send a WWW-Authenticate
header field containing at least one challenge
BREAKING CHANGE: Add new parameter to the init method of class HTTPUnauthorized
to add determine authentication scheme in the WWW-Authenticate header field when a
401 (Unauthorized) is generated