Fix DefaultRouter conflict bug #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DefaultRouter will now allow static routes to be placed before simple variable ones. Placing static routes after simple variable ones still raises a ValueError since they would be unreachable.
| @@ -206,7 +206,7 @@ def line(text, indent_offset=0): | |||
| # /foo/{id}/bar | |||
| # /foo/{name}/bar | |||
| # | |||
| assert len(nodes) == 1 | |||
| assert len([node for node in nodes if node.is_var]) == 1 | |||
There was a problem hiding this comment.
This is a simple test to just check there is not more than one variable, perhaps something more robust with order checking would be helpful.
ghost
mentioned this pull request
|
LGTM. Thanks! |
kgriffs
added a commit
that referenced
this pull request
May 1, 2015
fix(DefaultRouter): Regression with mixed static and dynamic route segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DefaultRouter will now allow static routes to be placed before
simple variable ones. Placing static routes after simple variable ones
still raises a ValueError since they would be unreachable.